On Fri, Dec 20, 2024 at 12:04 AM Linus Walleij linus.walleij@linaro.org wrote:
On Thu, Dec 19, 2024 at 7:50 PM david regan dregan@broadcom.com wrote:
Update bcmbca dts to current nand node naming convention.
Signed-off-by: david regan dregan@broadcom.com Reviewed-by: William Zhang william.zhang@broadcom.com Reviewed-by: Anand Gore anand.gore@broadcom.com
Looks like a reasonable step Acked-by: Linus Walleij linus.walleij@linaro.org
But:
nandcs@0 {compatible = "brcm,nandcs";reg = <0>;nand-ecc-strength = <4>;nand-ecc-step-size = <512>;brcm,nand-oob-sector-size = <16>;};+&nandcs {
nand-on-flash-bbt;nand-ecc-strength = <4>;nand-ecc-step-size = <512>;brcm,nand-oob-sector-size = <16>;So you're adding nand-on-flash-bbt, maybe we should notice this?
We don't need this option, I'll remove it.
Do you have to use the explicit ECC config, or can you just use Williams new option brcm,nand-ecc-use-strap; ?
Looks like Phillipe Reynes created this file, Phillipe do you have a preference?
(This can be changed in an additional patch.)
Yours, Linus Walleij
Thanks for your input!
-Dave