Hi Tom,
On 30 July 2014 16:38, Tom Rini trini@ti.com wrote:
On Wed, Jul 30, 2014 at 03:49:46AM -0600, Simon Glass wrote:
Change the Exynos serial driver to work with driver model and switch over all Exynos5 boards to use it.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v3:
- Avoid reordering functions
Yay.
@@ -108,14 +91,11 @@ static int serial_init_dev(const int dev_index) /* No interrupts, no DMA, pure polling */ writel(0x245, &uart->ucon);
serial_setbrg_dev(dev_index);return 0;}
So setbrg is called elsewhere, in a more common area? That's documented somewhere right?
Yes, and sort-of. Since you don't have a baud rate at init time you could only set a default value anyway. I'll add a comment to the serial.h uclass.
This seems otherwise to be a straight-forward conversion. Things we used to loop for in the driver are now handled a bit higher up and otherwise we find what to talk to in a slightly different manner.
Yes it's not too bad, if you ignore all the multi-serial mush being deleted. I felt that looping in a driver waiting for a character was a bad idea (how serial_getc() used to work).
Regards, Simon