On Tue, Jan 09, 2024 at 01:14:55PM -0600, Nishanth Menon wrote:
This is a wide cleanup to switch to setting fdtfile using env_set instead of scripted magic. 'fdtfile' is expected to be set by default. This allows the stdboot triggered efi loaders to find the correct OS device tree file even if regular boot process is interrupted by user intervention.
This is a refresh of https://lore.kernel.org/all/86le9dwz4d.fsf@udb0321960.dhcp.ti.com/ which was the wrong approach.
Updates from V1:
- Renames of variables and macros for various review comments.
- Commit message updates in some patches for clarity.
Bootlogs: https://gist.github.com/nmenon/843e343cde645ec4aa57b60cece5256a
based on master: c5e461fbf7cc Merge tag 'u-boot-imx-master-20240108' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx
NOTE: There are a couple of checkpatch WARN (around LATE_INIT) and CHECK (fdt_ops #ifdeffery) that on closer inspection looks fine and consistent with other similar usage.
V1: https://lore.kernel.org/all/20240108173301.2692332-1-nm@ti.com/
Unfortunately this FTB's on omap3_evm omap4_panda omap4_sdp4430: board/ti/common/fdt_ops.c: In function 'ti_set_fdt_env': board/ti/common/fdt_ops.c:39:34: error: 'CONFIG_TI_FDT_FOLDER_PATH' undeclared (first use in this function) 39 | CONFIG_TI_FDT_FOLDER_PATH, CONFIG_DEFAULT_FDT_FILE); | ^~~~~~~~~~~~~~~~~~~~~~~~~ board/ti/common/fdt_ops.c:39:34: note: each undeclared identifier is reported only once for each function it appears in And even tho I should delete omap4_panda and omap4_sdp4430, omap3_evm is maintained. It also FTB's on am62x_evm_a53: board/ti/am62x/evm.c: In function 'board_late_init': board/ti/am62x/evm.c:60:9: error: implicit declaration of function 'ti_set_fdt_env' [-Werror=implicit-function-declaration] 60 | ti_set_fdt_env(NULL, NULL); | ^~~~~~~~~~~~~~