On Mon, Sep 28, 2015 at 09:22:35PM +0200, Hans de Goede wrote:
Hi,
On 28-09-15 17:10, Tom Rini wrote:
On Wed, Sep 23, 2015 at 10:25:35AM -0700, Ryan Harkin wrote:
As config migrates from board config files to Kconfig, when adding CONFIG_SYS_BOOTM_LEN to a platform, I decided to add Kconfig support for CONFIG_SYS_BOOTM_LEN.
Signed-off-by: Ryan Harkin ryan.harkin@linaro.org Reviewed-by: Linus Walleij linus.walleij@linaro.org CC: Masahiro Yamada yamada.m@jp.panasonic.com CC: Simon Glass sjg@chromium.org CC: Linus Walleij linus.walleij@linaro.org
Thanks for trying to do this. The problem however is that you need to use tools/moveconfig.py so that all of the other boards (which is a lot) get updated too, otherwise they fail to build.
No, just no, not more polluting of defconfig files with things which really belong in a per SoC file not a per board file.
Well, we should be putting SoC/arch-specific stuff into the defaults and also using this as a chance to look at places where defaults differ pointlessly.
But, I also hear your concern. I see Masahiro has been working with merge_config.sh from the kernel in the kernel. How crazy would it be to re-work things (in some cases..) to have a merge in the config process so that there could be a sunxi-common config fragment. Or can/should we really just use default foo if Y in more places.