RE: [PATCH v2 2/2] mmc: stm32_sdmmc2: Use mmc_of_parse() to read host capabilities

Hi,

From: Alexandru Gagniuc mr.nuke.me@gmail.com Sent: mardi 15 septembre 2020 21:52

mmc_of_parse() can populate the 'f_max' and 'host_caps' fields of struct mmc_config from devicetree. The same logic is duplicated in stm32_sdmmc2_probe(). Use mmc_of_parse(), which is more generic.

Signed-off-by: Alexandru Gagniuc mr.nuke.me@gmail.com

Changes from v1:

• Check the return value of mmc_of_parse().
• The call to mmc_of_parse() is moved further up. This means we can just 'return err' on error instead of exiting via goto.

drivers/mmc/stm32_sdmmc2.c | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-)

Reviewed-by: Patrick Delaunay patrick.delaunay@st.com

Thanks

Patrick