Hi Quentin,
On 2023/1/3 21:26, Quentin Schulz wrote:
From: Quentin Schulz quentin.schulz@theobroma-systems.com
The IRAM on PX30 (or Int_MEM in datasheet) starts at 0xff0e0000 and not 0xff020000 as rightfully stated in the FIXME comment.
Let's fix it so that BROM_BOOTSOURCE_ID_ADDR points to the correct address for PX30.
Fixes: 46281a76bee3 ("rockchip: add core px30 headers") Cc: Quentin Schulz foss+uboot@0leil.net Reviewed-by: Kever Yang kever.yang@rock-chips.com Signed-off-by: Quentin Schulz quentin.schulz@theobroma-systems.com
include/configs/px30_common.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/configs/px30_common.h b/include/configs/px30_common.h index 49d1878ebd..c93bb053a5 100644 --- a/include/configs/px30_common.h +++ b/include/configs/px30_common.h @@ -10,8 +10,7 @@
#define CONFIG_SYS_NS16550_MEM32
-/* FIXME: ff020000 is pmu_mem (10k), while ff0e0000 is regular int_mem */ -#define CONFIG_IRAM_BASE 0xff020000 +#define CONFIG_IRAM_BASE 0xff0e0000
This should be CFG_IRAM_BASE.
Please check mainline/next.
Thanks,
- Kever
#define GICD_BASE 0xff131000 #define GICC_BASE 0xff132000