Re: [U-Boot] [PATCH v3 3/6] mx28evk: Add support to dynamically choose between ftd use or not

On Mon, Jan 7, 2013 at 2:51 PM, Fabio Estevam festevam@gmail.com wrote:

On Mon, Jan 7, 2013 at 2:43 PM, Otavio Salvador otavio@ossystems.com.br wrote:

...

    "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \

•   "loadftd=fatload mmc ${mmcdev}:${mmcpart} ${ftd_addr} ${ftd_file}\0" \
    "mmcboot=echo Booting from mmc ...; " \
            "run mmcargs; " \
  

•           "bootm\0" \
  

•           "if test ${boot_fdt} = yes; then " \
  

•                   "if run loadfdt; then " \
  

•                           "bootm ${loadaddr} - ${ftd_addr}; " \
  

•                   "else " \
  

•                           "if test ${boot_fdt} = try; then " \
  

•                                   "bootm; " \
  

•                           "else " \
  

•                                   "echo ERROR: Cannot load the DT, aborting...; " \
  

•                                   "exit; " \
  

Current behavior is to try to load uImage from mmc first, if it fails then it tries tftp.

Isn't this 'exit' that you introduced preventing tftp transfer in the case of mmc fail?

Yes; it will go out and won't try tftp. In this case I can remove the exit and change the ERROR to WARNINF. What do you think?

Also, can you confirm that your patchset works in the following cases:

1. Loading a non-dt kernel via mmc
2. Loading a dt kernel via mmc
3. Loading a non-dt kernel via tftp
4. Loading a dt kernel via tftp

Yes; it is the same patchset we applied in OE.

-- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br