Hi Simon,
On 11/19/24 2:18 PM, Simon Glass wrote:
Rather than building a command line for each operation, use the functions provided by the bootm API.
Make sure that the bootm functions are available if pxe_utils is used.
Since SYS_BOOTM_LEN is not present for the tools-only build, adjust the code to handle that.
Signed-off-by: Simon Glass sjg@chromium.org
boot/Makefile | 2 +- boot/pxe_utils.c | 43 ++++++++++++++++++++----------------------- 2 files changed, 21 insertions(+), 24 deletions(-)
diff --git a/boot/Makefile b/boot/Makefile index 43def7c33d7..9ccdc2dc8f4 100644 --- a/boot/Makefile +++ b/boot/Makefile @@ -10,7 +10,7 @@ obj-$(CONFIG_CMD_BOOTM) += bootm.o bootm_os.o obj-$(CONFIG_CMD_BOOTZ) += bootm.o bootm_os.o obj-$(CONFIG_CMD_BOOTI) += bootm.o bootm_os.o
-obj-$(CONFIG_PXE_UTILS) += pxe_utils.o +obj-$(CONFIG_PXE_UTILS) += bootm.o pxe_utils.o
endif
diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c index 66f82d3fbc1..2517999d408 100644 --- a/boot/pxe_utils.c +++ b/boot/pxe_utils.c @@ -7,6 +7,7 @@ #define LOG_CATEGORY LOGC_BOOT
#include <bootflow.h> +#include <bootm.h> #include <command.h> #include <dm.h> #include <env.h> @@ -461,7 +462,7 @@ skip_overlay:
- Scenario 4: fdt blob is not available.
*/ static int label_process_fdt(struct pxe_context *ctx, struct pxe_label *label,
char *kernel_addr, char **fdt_argp)
char *kernel_addr, const char **fdt_argp)@@ -584,72 +585,66 @@ static int label_run_boot(struct pxe_context *ctx, struct pxe_label *label, char *kernel_addr, char *initrd_addr_str, char *initrd_filesize, char *initrd_str) {
- char *bootm_argv[] = { "bootm", NULL, NULL, NULL, NULL }; char *zboot_argv[] = { "zboot", NULL, "0", NULL, NULL };
- struct bootm_info bmi; ulong kernel_addr_r;
int bootm_argc = 2; int zboot_argc = 3; void *buf; int ret;
bootm_argv[3] = env_get("fdt_addr_r");
- bootm_init(&bmi);
- ret = label_process_fdt(ctx, label, kernel_addr, &bootm_argv[3]);
- bmi.conf_fdt = env_get("fdt_addr_r");
- ret = label_process_fdt(ctx, label, kernel_addr, &bmi.conf_fdt); if (ret) return ret;
- bootm_argv[1] = kernel_addr;
bmi.addr_img = kernel_addr; zboot_argv[1] = kernel_addr;
if (initrd_addr_str) {
bootm_argv[2] = initrd_str;bootm_argc = 3;
bmi.conf_ramdisk = initrd_str;zboot_argv[3] = initrd_addr_str; zboot_argv[4] = initrd_filesize; zboot_argc = 5; }
- if (!bootm_argv[3]) {
- if (!bmi.conf_fdt) { if (IS_ENABLED(CONFIG_SUPPORT_PASSING_ATAGS)) { if (strcmp("-", label->fdt))
bootm_argv[3] = env_get("fdt_addr");
bmi.conf_fdt = env_get("fdt_addr");
bootm_argv[3] = env_get("fdt_addr");
bmi.conf_fdt = env_get("fdt_addr");} }
kernel_addr_r = genimg_get_kernel_addr(kernel_addr); buf = map_sysmem(kernel_addr_r, 0);
- if (!bootm_argv[3] && genimg_get_format(buf) != IMAGE_FORMAT_FIT) {
- if (!bmi.conf_fdt && genimg_get_format(buf) != IMAGE_FORMAT_FIT) { if (IS_ENABLED(CONFIG_SUPPORT_PASSING_ATAGS)) { if (strcmp("-", label->fdt))
bootm_argv[3] = env_get("fdtcontroladdr");
bmi.conf_fdt = env_get("fdtcontroladdr");
bootm_argv[3] = env_get("fdtcontroladdr");
bmi.conf_fdt = env_get("fdtcontroladdr");
Unrelated remark:
This could be shortened to
if (!IS_ENABLED(CONFIG_SUPPORT_PASSING_ATAGS) || strcmp("-", label->fdt)) bmi.conf_fdt = env_get("fdtcontroladdr");
Same for a few lines above.
}
- if (bootm_argv[3]) {
if (!bootm_argv[2])bootm_argv[2] = "-";bootm_argc = 4;- }
- /* Try bootm for legacy and FIT format image */ if (genimg_get_format(buf) != IMAGE_FORMAT_INVALID && IS_ENABLED(CONFIG_CMD_BOOTM)) { log_debug("using bootm\n");
do_bootm(ctx->cmdtp, 0, bootm_argc, bootm_argv);
ret = bootm_run(&bmi);
do_booti(ctx->cmdtp, 0, bootm_argc, bootm_argv);
ret = booti_run(&bmi);
do_bootz(ctx->cmdtp, 0, bootm_argc, bootm_argv);
ret = bootz_run(&bmi);@@ -657,6 +652,8 @@ static int label_run_boot(struct pxe_context *ctx, struct pxe_label *label, }
unmap_sysmem(buf);
if (ret)
return ret;return 0;
simply
return ret;
?
Reviewed-by: Quentin Schulz quentin.schulz@cherry.de
Thanks! Quentin