
2 Apr
2008
2 Apr
'08
5:29 p.m.
Andy Fleming wrote:
The fdt set command was treating properties specified as <00> and <0011> as byte streams, rather than as an array of cells. As we already have syntax for expressing the desire for a stream of bytes ([ xx xx ...]), we should use the <> syntax to describe arrays of cells, which are always 32-bits per element. If we imagine this likely (IMHO) scenario:
fdt set /ethernet-phy@1 reg <1>
With the old code, this would create a bad fdt, since the reg cell would be made to be one byte in length. But the cell must be 4 bytes, so this would break mysteriously.
Confirmed, my bad. Applied to the u-boot-fdt repo.
Thanks, gvb