Hi Peng,
On 04/01/2016 08:26, Peng Fan wrote:
From: "Ye.Li" B37916@freescale.com
it is enough to have Ye in the Signed-off instead of the commit message.
According to the Coverity result, a unsigned int variable is used fo less- than-zero comparison, the result is never true. Need to fix the variable type to signed int.
Signed-off-by: Ye.Li B37916@freescale.com Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Przemyslaw Marczak p.marczak@samsung.com Cc: Stefano Babic sbabic@denx.de
board/freescale/common/pfuze.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/board/freescale/common/pfuze.c b/board/freescale/common/pfuze.c index 783c46d..69afa83 100644 --- a/board/freescale/common/pfuze.c +++ b/board/freescale/common/pfuze.c @@ -13,7 +13,8 @@ int pfuze_mode_init(struct pmic *p, u32 mode) { unsigned char offset, i, switch_num;
- u32 id, ret;
u32 id;
int ret;
pmic_reg_read(p, PFUZE100_DEVICEID, &id); id = id & 0xf;
Apart of that:
Reviewed-by: Stefano Babic sbabic@denx.de
Best regards, Stefano Babic