Hello Piotr,
On 06.05.24 16:07, Heiko Schocher wrote:
Hello Piotr,
On 30.04.24 12:23, Piotr Wojtaszczyk wrote:
Signed-off-by: Piotr Wojtaszczyk piotr.wojtaszczyk@timesys.com
fs/ubifs/ubifs-media.h | 2 ++ fs/ubifs/ubifs.c | 55 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 55 insertions(+), 2 deletions(-)
Looks good to me, thanks!
Acked-by: Heiko Schocher hs@denx.de
Just tried to apply your patch (sorry for being so late) and checkpatch dropped some warnings, see below. Could you please fix them?
Thanks!
bye, Heiko [1] checkpatch warnings
WARNING: Missing commit description - Add an appropriate one
WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #160: FILE: fs/ubifs/ubifs.c:30: +#if IS_ENABLED(CONFIG_ZSTD)
WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #172: FILE: fs/ubifs/ubifs.c:50: +#if IS_ENABLED(CONFIG_ZSTD)
CHECK: Alignment should match open parenthesis #174: FILE: fs/ubifs/ubifs.c:52: +static int zstd_decompress_wrapper(const unsigned char *in, size_t in_len, + unsigned char *out, size_t *out_len)
WARNING: braces {} are not necessary for single statement blocks #183: FILE: fs/ubifs/ubifs.c:61: + if (ret < 0) { + return ret; + }
WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #199: FILE: fs/ubifs/ubifs.c:99: +#if IS_ENABLED(CONFIG_ZSTD)
CHECK: Please don't use multiple blank lines #212: FILE: fs/ubifs/ubifs.c:112: + +
CHECK: Alignment should match open parenthesis #231: FILE: fs/ubifs/ubifs.c:215: + ubifs_err(c, "%s compression is not compiled in", + compr->name ? compr->name : "unknown");
WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #239: FILE: fs/ubifs/ubifs.c:280: +#if IS_ENABLED(CONFIG_ZSTD)
total: 0 errors, 6 warnings, 3 checks, 101 lines checked
NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace.
mbox has style problems, please review.
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO ENOSYS MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Wende an: fs: ubifs: Add support for ZSTD decompression