Hi Philipp,
在 2018年02月19日 03:38, Philipp Tomsich 写道:
On Sat, 3 Feb 2018, David Wu wrote:
In fact, the evb-rk3229 is default supported the integrated phy, not need to change any hardware. So it is better to enbale it and disable external 1000M phy.
Signed-off-by: David Wu david.wu@rock-chips.com Acked-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
arch/arm/dts/rk3229-evb.dts | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
diff --git a/arch/arm/dts/rk3229-evb.dts b/arch/arm/dts/rk3229-evb.dts index ae0b0a4..547c7a2 100644 --- a/arch/arm/dts/rk3229-evb.dts +++ b/arch/arm/dts/rk3229-evb.dts @@ -63,7 +63,29 @@ snps,reset-delays-us = <0 10000 1000000>; tx_delay = <0x30>; rx_delay = <0x10>; + status = "disabled"; +};
+&gmac { + assigned-clocks = <&cru SCLK_MAC_SRC>; + assigned-clock-rates = <50000000>; + clock_in_out = "output"; + phy-supply = <&vcc_phy>; + phy-mode = "rmii"; + phy-handle = <&phy>; status = "okay";
+ mdio { + compatible = "snps,dwmac-mdio"; + #address-cells = <1>; + #size-cells = <0>;
+ phy: phy@0 { + compatible = "ethernet-phy-id1234.d400", "ethernet-phy-ieee802.3-c22";
Where is "ethernet-phy-id1234.d400" defined/used? I don't see anything in Linux or U-Boot.
Yes, The "ethernet-phy-id1234.d400" is not defined at linux/U-Boot. It does use the "ethernet-phy-ieee802.3-c22". The "ethernet-phy-id1234.d400" is a decorated aliases, the 0x1234d0 is the phy-id.
+ reg = <0>; + phy-is-integrated;
Documentation in the documentation for DTS bindings? Shouldn't this be rockchip,phy-is-integrated? What is the status of this on the Linux side?
I think it's consistent with kernel, especially if we might use kernel DTB file.
+ }; + }; };
&emmc {