Hi Rob,
On Thu, 05 Jul 2012 16:31:15 -0500, Rob Herring robherring2@gmail.com wrote:
Albert,
On 07/05/2012 05:10 AM, Albert ARIBAUD wrote:
Hi Rob,
On Thu, 28 Jun 2012 08:54:10 -0500, Rob Herring robherring2@gmail.com wrote:
From: Rob Herring rob.herring@calxeda.com
CONFIG_STACKSIZE is not referenced anywhere except on AVR32, but present in most ARM boards. The IRQ and FIQ stacks are not setup in start.S, but arch/arm/lib/board.c, so also remove those comments.
Not sure I understand the last point. Can you clarify? How does this relate to keeping FIQ / IRQ stack size declarations in config files? E.g.:
The irq and fiq stack sizes are setup in arch/arm/lib/board.c, not start.S as the comment suggested.
There's only 2 boards that turn on USE_IRQ and I'm not convinced they would actually work after a brief look. Perhaps we should just remove all the defines except from those 2 boards.
I would appreciate indeed it if these unused defines were removed.
Whether the two boards which actually use IRQs would work or not is a separate issue which board maintainers or users should handle if they want to.
Rob
Amicalement,