-----Original Message----- From: York Sun [mailto:york.sun@nxp.com] Sent: Friday, May 12, 2017 9:31 PM To: Santan Kumar santan.kumar@nxp.com; u-boot@lists.denx.de Cc: Priyanka Jain priyanka.jain@nxp.com; Abhimanyu Saini abhimanyu.saini@nxp.com Subject: Re: [PATCH 2/2][v5] armv8: ls2080aqds: Add support for SD boot
On 05/05/2017 03:10 AM, Santan Kumar wrote:
Signed-off-by: Santan Kumar santan.kumar@nxp.com Signed-off-by: Priyanka Jain priyanka.jain@nxp.com Signed-off-by: Abhimanyu Saini abhimanyu.saini@nxp.com
Changes in v5:
- Update MAINTAINERS file
- Updated the memory layout
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 6 +-- .../cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c | 6 +-- board/freescale/ls2080a/ls2080a.c | 6 +-- board/freescale/ls2080aqds/MAINTAINERS | 1 + board/freescale/ls2080aqds/README | 13 +++++ board/freescale/ls2080aqds/eth.c | 8 +--- board/freescale/ls2080aqds/ls2080aqds.c | 4 +- configs/ls2080aqds_sdcard_defconfig | 55
++++++++++++++++++++++
include/configs/ls2080a_common.h | 9 +++- include/configs/ls2080aqds.h | 27 ++++++++++- 10 files changed, 116 insertions(+), 19 deletions(-) create mode 100644 configs/ls2080aqds_sdcard_defconfig
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c index bb02960..e5da7a2 100644 --- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c +++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c @@ -462,7 +462,7 @@ int cpu_eth_init(bd_t *bis) { int error = 0;
-#ifdef CONFIG_FSL_MC_ENET +#if defined(CONFIG_FSL_MC_ENET) && !defined(CONFIG_SPL_BUILD)
You have many changes like this in this patch. Why don't you change the Kconfig
--- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig @@ -96,7 +96,7 @@ config FSL_LSCH3 config FSL_MC_ENET bool "Management Complex network" depends on ARCH_LS2080A
default y
default y if !SPL_BUILD select RESV_RAM help Enable Management Complex (MC) networkPlease try it.
York
[Santan Kumar] I have already tried it. SPL_BUILD flag was not enabled when we this code is executing. That's why I haven't added it in Kconfig.