Re: [U-Boot] [PATCH 5/6] usb:g_dnl: Support for g_dnl download usb gadget for GONI board

Dear Lukasz Majewski,

In message 1334215049-20362-6-git-send-email-l.majewski@samsung.com you wrote:

Support for g_dnl download usb gadget driver for Samsung's GONI target.

...

+void usbd_thor_udc_probe(void) +{

• puts("USB_udc_probe\n");
• s3c_udc_probe(&s5pc110_otg_data);

Less verbose?

-#define CONFIG_BOOTCOMMAND "run ubifsboot" +#define CONFIG_BOOTCOMMAND "run mmcboot"

This appears tio be an unrelated change, please submit separately.

+#define CONFIG_DNL_INFO \

• "dnl_info=" \
• "u-boot mmc 80 200;" \
• "uImage fat 0 2;" \
• "platform.img raw 0 3\0" \

Here we really see that documentation is missing. It is not clear how this is supposed to be used. As is, it appears as if this concept didn't scale.

• "mmcboot=" \

• "set bootargs root=${mmcblk} rootfstype=${rootfstype}" \
  

• CONFIG_UBI_MTD " ${opts} ${lcdinfo} " \
  

• CONFIG_COMMON_BOOT "; run bootk\0" \
  

• "mmcboot=set bootargs root=/dev/mmcblk${mmcdev}p${mmcrootpart} " \

• "rootwait ${console} ${meminfo} ${opts} ${lcdinfo}; " \
  

• "run loaduimage; bootm 0x30007FC0\0" \
  

Unrelated change.

• "opts=always_resume=1"

• "loaduimage=fatload mmc ${mmcdev}:${mmcbootpart} 0x30007FC0 uImage\0" \
• "mmcdev=0\0" \
• "mmcbootpart=2\0" \
• "mmcrootpart=3\0" \
• "opts=always_resume=1\0" \

Unrelated changes.

Best regards,

Wolfgang Denk