Re: [U-Boot] [PATCH 03/11] fdt: Export the fdt_find_or_add_subnode() function

Hi Simon,

On Wed, 15 Oct 2014 02:05:33 -0600 Simon Glass sjg@chromium.org wrote: ...

diff --git a/common/fdt_support.c b/common/fdt_support.c index 3f64156..dc41222 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -112,17 +112,7 @@ int fdt_find_and_setprop(void *fdt, const char *node, const char *prop, return fdt_setprop(fdt, nodeoff, prop, val, len); }

-/**

• • fdt_find_or_add_subnode - find or possibly add a subnode of a given node
• • @fdt: pointer to the device tree blob
• • @parentoffset: structure block offset of a node
• • @name: name of the subnode to locate
• • fdt_subnode_offset() finds a subnode of the node with a given name.
• • If the subnode does not exist, it will be created.
• */

-static int fdt_find_or_add_subnode(void *fdt, int parentoffset,

• 		   const char *name)
  

the function documentation comment should remain here, I think.

Thanks,

Anatolij