Re: [U-Boot] [PATCH 1/2] video: fix bug in logo_plot

Jean-Christophe PLAGNIOL-VILLARD wrote:

<snip>

...

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c index 68b9861..97a37ba 100644 --- a/drivers/video/cfb_console.c +++ b/drivers/video/cfb_console.c @@ -1071,7 +1071,9 @@ void logo_plot (void *screen, int width, int x, int y) int ycount = VIDEO_LOGO_HEIGHT; unsigned char r, g, b, *logo_red, *logo_blue, *logo_green; unsigned char *source;

• unsigned char *dest = (unsigned char *)screen + ((y * width * VIDEO_PIXEL_SIZE) + x);

• unsigned char *dest = (unsigned char *)screen +

• 	      ((y * width * VIDEO_PIXEL_SIZE) +
  

• 	       x * VIDEO_PIXEL_SIZE);
  

why not simplify it?

...

• unsigned char *dest = (unsigned char *)screen +

• 	      ((y * width + x) * VIDEO_PIXEL_SIZE);
  

we could also drop the cast then. How about

+ unsigned char *dest = screen + (y * width + x) * VIDEO_PIXEL_SIZE; ?