Hello Wolfgang,
thank you for your fast review!
On Tuesday 08 January 2013 at 19:58:37, Wolfgang Denk wrote:
+/* DDR RAM defines */ +#define DDR_CLK_MHZ 303
Is this really correct? 303 ??
I am quite sure, I read this in a datasheet, but I can not find it anymore. I set this to 333 now. mtest still works.
...
Do you plan to use this? Otherwise please just omit such dead code.
+#ifdef CONFIG_DRIVER_TI_CPSW +static void cpsw_control(int enabled) +{
- /* VTP can be added here */
- return;
+}
Ditto...
The cpsw driver needs a control function, otherwise the board crashes when network initializes. On my board this is empty like on am335x_evm.
+#define CONFIG_ENV_OVERWRITE 1
Please do not define values for logical variables like this one; please fix globally.
Fix globally ? Do you mean, I have to fix that for EVERY board that is in u- boot, that defines CONFIG_ENV_OVERWRITE with a value to get my patch in? There are a number of boards doing this wrong!
+#define CONFIG_ENV_IS_NOWHERE
Really?
Uuhm. Yes. At the moment I use this uEnv.txt file on sd-card, as I am not able to use the NAND yet. The env should go to nand later.
Thanks for the other hints you gave. I will address this and send a version 2 soon.
Regards, Lars