Re: [U-Boot] [PATCH 6/8] nhk8815: added keypad

Dear Alessandro Rubini,

In message <5a9bb8fb15cdb47d2ccd77af62f759ed493de944.1255086085.git.rubini@ unipv.it> you wrote:

From: Alessandro Rubini rubini@unipv.it

Signed-off-by: Alessandro Rubini rubini@unipv.it Acked-by: Andrea Gallo andrea.gallo@stericsson.com

Please see previous comments about coding style.

Additionally:

+int nhk8815_keypad_init(void) +{

•    struct stdio_dev dev;
  

Indentation by TAB only, please.

• printf("%s:%s\n", __FILE__, __func__);

Guess this should be debug() instead?

Best regards,

Wolfgang Denk