Hi Wolfgang,
Dear Axel Beierlein,
In message 1248471861-8085-1-git-send-email-beierlein@goetting.de you wrote:
Signed-off-by: Axel Beierlein beierlein@goetting.de
Makefile | 7 +++++++ board/tqc/tqm5200/tqm5200.c | 9 ++++++++- include/configs/TQM5200.h | 33 ++++++++++++++++++++++++++------- 3 files changed, 41 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile index 2a06440..7f197dd 100644 --- a/Makefile +++ b/Makefile @@ -764,6 +764,7 @@ Total5200_Rev2_lowboot_config: unconfig } @$(MKCONFIG) -a Total5200 ppc mpc5xxx total5200
+HG43630_config \ cam5200_config \ cam5200_niosflash_config \ fo300_config \
Please use a lower case board name, and keep list sorted.
@@ -808,6 +809,12 @@ TQM5200_STK100_config: unconfig @[ -z "$(findstring HIGHBOOT,$@)" ] || \ { echo "TEXT_BASE = 0xFFF00000" >$(obj)board/tqm5200/config.tmp ; \ }
- @[ -z "$(findstring HG43630,$@)" ] || \
{ echo "#define CONFIG_HG43630" >>$(obj)include/config.h ; \echo "#define CONFIG_TQM5200S" >>$(obj)include/config.h ; \echo "#define CONFIG_TQM5200_B" >>$(obj)include/config.h ; \$(XECHO) "... TQM5200S on Goetting HG43630 Board" ; \}Please don't add board specific configuration to the top level Makefile; do thi sin your board config file instead.
Can you explain what you want to see here? The board is based on a tqm5200 module, so he actually does not want to copy his own config file. Personally I think this solution to be ok, can you explain what you don't like about it?
Cheers Detlev