Re: [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes

On 07/21/2015 03:36 AM, Mirza Krak wrote:

From: Mirza Krak mirza.krak@hostmobility.com

Add the device tree node for the SPI controllers found on Tegra20 SOCs.

diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi

• spi@7000d400 {

• compatible = "nvidia,tegra20-slink";
  

• reg = <0x7000d400 0x200>;
  

• interrupts = <0 59 0x04>;
  

• nvidia,dma-request-selector = <&apbdma 15>;
  

That property doesn't seem to exist in the kernel DT, and "resets", "reset-names", "dmas", "dma-names" are missing. I'd suggest simply cutting/pasting from the kernel DT to make sure they stay in sync.

interrupts and clocks should also use the #defines to provide named constants for better readability and the same consistency reasons.