-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/10/13 16:08, Tom Rini wrote:
On Thu, Mar 14, 2013 at 05:32:50AM -0000, Tom Rini wrote:
We make these two functions take a size_t pointer to how much space was used on NAND to read or write the buffer (when reads/writes happen) so that bad blocks can be accounted for. We also make them take an loff_t limit on how much data can be read or written. This means that we can now catch the case of when writing to a partition would exceed the partition size due to bad blocks. To do this we also need to make check_skip_len count not just complete blocks used but partial ones as well. All callers of nand_(read|write)_skip_bad are adjusted to call these with the most sensible limits available.
The changes were started by Pantelis and finished by Tom.
Signed-off-by: Pantelis Antoniou panto@antoniou-consulting.com Signed-off-by: Tom Rini trini@ti.com
With current master, the following changes are needed to adapt cm_t35 to these call changes:
I guess, you will squash both patches into one, right?
Acked-by: Igor Grinberg grinberg@compulab.co.il
diff --git a/board/cm_t35/cm_t35.c b/board/cm_t35/cm_t35.c index 629ce4a..84c36ba 100644 --- a/board/cm_t35/cm_t35.c +++ b/board/cm_t35/cm_t35.c @@ -91,6 +91,7 @@ static int splash_load_from_nand(u32 bmp_load_addr)
res = nand_read_skip_bad(&nand_info[nand_curr_device], splash_screen_nand_offset, &bmp_header_size,
NULL, nand_info[nand_curr_device].size, (u_char *)bmp_load_addr);@@ -103,6 +104,7 @@ static int splash_load_from_nand(u32 bmp_load_addr)
return nand_read_skip_bad(&nand_info[nand_curr_device], splash_screen_nand_offset, &bmp_size,
NULL, nand_info[nand_curr_device].size, (u_char *)bmp_load_addr);splash_address_too_high:
- -- Regards, Igor.