On 03.12.2016 19:31, Simon Glass wrote:
On 03.12.2016 05:26, Simon Glass wrote:
On 28 November 2016 at 05:38, Stefan Roese sr@denx.de wrote:
From: Shadi Ammouri shadi@marvell.com
This patch adds a driver for the PCIe controller integrated in the Marvell Armada-8K SoC. This controller is based on the DesignWare IP core.
The original version was written by Shadi and Yehuda. I ported this driver to the latest mainline U-Boot version with DM support.
Tested on the Marvell DB-88F8040 Armada-8K eval board.
Signed-off-by: Shadi Ammouri shadi@marvell.com Signed-off-by: Yehuda Yitschak yehuday@marvell.com Signed-off-by: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org Cc: Nadav Haklai nadavh@marvell.com Cc: Neta Zur Hershkovits neta@marvell.com Cc: Kostya Porotchkin kostap@marvell.com Cc: Omri Itach omrii@marvell.com Cc: Igal Liberman igall@marvell.com Cc: Haim Boot hayim@marvell.com Cc: Hanna Hawa hannah@marvell.com
v2:
- Removed host struct from private data struct
- Added comments to structs and functions
- Moved shift into the macro for PCIE_LINK_STATUS_SPEED_MASK and PCIE_LINK_STATUS_WIDTH_MASK
- Added Email addresses to ToDo statement
- Used clrsetbits_le32(9 where applicable
- Added const to register base pointer
- Used new core function dev_get_addr_size_index() to retrieve addr and size
- Added code to configure the PCIe root complex device as PCI bridge device
drivers/pci/Kconfig | 10 + drivers/pci/Makefile | 1 + drivers/pci/pcie_dw_mvebu.c | 535 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 546 insertions(+)
Reviewed-by: Simon Glass sjg@chromium.org
Thanks.
I would like to integrate this PCIE driver in my next mvebu pull request, introducing the Armada 8K support. But it depends on the DM patch "dm: core: Add dev_get_addr_size_index() to retrieve addr and size". What is your plan with this one? Will you pull this patch soon? Or should I pull it with my mvebu patch series?
I did have a second set of patches including this. So I've pushed it into dm/master and sent an updated pull request.
Thanks Simon!