On Mon, 29 Oct 2018 16:29:43 +0100 Loic Devulder ldevulder@suse.de wrote:
Hi!
On 10/28/18 10:19 PM, Vasily Khoruzhick wrote:
Pinebook is a laptop produced by Pine64, with USB-connected keyboard, USB-connected touchpad and an eDP LCD panel connected via a RGB-eDP bridge from Analogix.
Signed-off-by: Vasily Khoruzhick anarsoul@gmail.com Acked-by: Maxime Ripard maxime.ripard@bootlin.com Tested-by: Maxime Ripard maxime.ripard@bootlin.com Cc: Vagrant Cascadian vagrant@debian.org
arch/arm/dts/Makefile | 1 + arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi | 15 + arch/arm/dts/sun50i-a64-pinebook.dts | 294 +++++++++++++++++++ configs/pinebook_defconfig | 22 ++ 4 files changed, 332 insertions(+) create mode 100644 arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi create mode 100644 arch/arm/dts/sun50i-a64-pinebook.dts create mode 100644 configs/pinebook_defconfig
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 0de6234eec..94ec15a8ac 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -405,6 +405,7 @@ dtb-$(CONFIG_MACH_SUN50I) += \ sun50i-a64-orangepi-win.dtb \ sun50i-a64-pine64-plus.dtb \ sun50i-a64-pine64.dtb \
- sun50i-a64-pinebook.dtb \ sun50i-a64-sopine-baseboard.dtb
dtb-$(CONFIG_MACH_SUN9I) += \ sun9i-a80-optimus.dtb \ diff --git a/arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi b/arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi new file mode 100644 index 0000000000..a99b7171d0 --- /dev/null +++ b/arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi @@ -0,0 +1,15 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/*
- Copyright (C) 2018 Vasily Khoruzhick anarsoul@gmail.com
- */
+/* The ANX6345 eDP-bridge is on r_i2c */ +&r_i2c {
- anx6345: edp-bridge@38 {
compatible = "analogix,anx6345";reg = <0x38>;reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24*/
status = "okay";- };
+};
Maybe I missed something but I don't see when this dtsi file is used or included.
Yeah, that's some non-obvious U-Boot build magic: Whenever there is a file which has "-u-boot.dtsi" appended to certain .dts filename stubs, U-Boot includes this file when building the .dtb. This is supposed to be used to add U-Boot specific DT nodes or properties to some otherwise unchanged (read: Linux mainline) DTs. Check scripts/Makefile.lib and search for u-boot.dtsi for the source.
Cheers, Andre.