Grant Likely wrote:
I know that slightly modified duplicate code is common in u-boot, so this is not an critique on your work, but I'd really like to move away from this mode of operation. Duplicating the original file and modifying it is certainly the easiest way to add support for a new
And It makes the code more readable. It's the pro.
10 times and a bug is found in it at a later date; the bug fix needs to be applied to 10 files, not one.
Yes, It's the con. But, how many times does it happen?.
Unfortunately, this situation is messy because the imx is in cpu/arm920t and imx32 is in cpu/arm926ejs. It probably requires the creation of a new directory for the common imx soc bits, but where? Perhaps under lib_arm/imx?
Ummm, lib_arm/imx?. I think this mixes up concepts. Why not to decouple the arm cores and the SoC code?. For example: cpu/arm/cores/arm926ejs cpu/arm/soc/imx Perhaps, there was a discussion about this in U-Boot and I'm talking nonsense. Anyway, you are the mainteiner so you have the last say. ;-)
Best regards, Txema.