Hi York,
-----Original Message----- From: york sun Sent: Friday, September 09, 2016 1:07 AM To: Q.Y. Gong qianyu.gong@nxp.com; u-boot@lists.denx.de Cc: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Vincent Hu mingkai.hu@nxp.com; S.H. Xie shaohui.xie@nxp.com; Z.Q. Hou zhiqiang.hou@nxp.com; Wenbin Song wenbin.song@nxp.com; Shengzhou Liu shengzhou.liu@nxp.com Subject: Re: [Patch v6 5/9] armv8: fsl-layerscape: spl: remove BSS clearing and board_init_r
On 09/07/2016 03:08 AM, Gong Qianyu wrote:
As per the top level U-Boot README "Board Initialisation Flow" section, board_init_f() should return without calling board_init_r() directly. Clearing BSS and calling board_init_r() will be done in crt0_64.S.
Signed-off-by: Gong Qianyu Qianyu.Gong@nxp.com
v6:
- No change.
v5:
- New Patch.
arch/arm/cpu/armv8/fsl-layerscape/spl.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/spl.c b/arch/arm/cpu/armv8/fsl-layerscape/spl.c index 19e34fa..b8e1d75 100644 --- a/arch/arm/cpu/armv8/fsl-layerscape/spl.c +++ b/arch/arm/cpu/armv8/fsl-layerscape/spl.c @@ -62,13 +62,8 @@ void board_init_f(ulong dummy) i2c_init_all(); #endif dram_init();
- /* Clear the BSS */
- memset(__bss_start, 0, __bss_end - __bss_start);
#ifdef CONFIG_LAYERSCAPE_NS_ACCESS enable_layerscape_ns_access(); #endif
- board_init_r(NULL, 0);
} #endif
Qianyu,
This looks OK but it breaks LS2080ARDB NAND boot. Please investigate.
York
I can boot it up with this patch set on star server: LS2085ARDB-1. I also tested the single patch and no issue.
This is my U-Boot command: =>tftp 82000000 b52263/ls2080ardb/u-boot-with-spl.bin;nand erase 80000 180000;nand write 82000000 80000 120000;qixis_reset nand
Regards, Qianyu