Re: [PATCH u-boot-marvell 16/19] net: mvneta: Write PHY address just before enabling HW polling

On Wed, Apr 27, 2022 at 1:42 PM Marek Behún kabel@kernel.org wrote:

From: Marek Behún marek.behun@nic.cz

Write PHY address just before enabling HW polling of the PHY.

Signed-off-by: Marek Behún marek.behun@nic.cz

drivers/net/mvneta.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c index 5b1c4fe5fc..4917857681 100644 --- a/drivers/net/mvneta.c +++ b/drivers/net/mvneta.c @@ -814,6 +814,8 @@ static void mvneta_defaults_set(struct mvneta_port *pp)

    /* Enable PHY polling in hardware if not in fixed-link mode */
    if (!pp->fixed_link) {

•           mvreg_write(pp, MVNETA_PHY_ADDR, pp->phydev->addr);
  

•           val = mvreg_read(pp, MVNETA_UNIT_CONTROL);
            val |= MVNETA_PHY_POLLING_ENABLE;
            mvreg_write(pp, MVNETA_UNIT_CONTROL, val);
  

@@ -1431,10 +1433,6 @@ static int mvneta_start(struct udevice *dev)

            pp->fixed_link = phydev->phy_id == PHY_FIXED_ID;

•           /* Set PHY address in case we will enable HW polling */
  

•           if (!pp->fixed_link)
  

•                   mvreg_write(pp, MVNETA_PHY_ADDR, phydev->addr);
  

•           pp->phydev = phydev;
            phy_config(phydev);
            phy_startup(phydev);
  

-- 2.35.1

Reviewed-by: Ramon Fried rfried.dev@gmail.com