Re: [U-Boot] [PATCH] drivers/block/systemace: fixes read/write words for bus width = 8

Dear Alexey Brodkin,

In message 1357137512-8618-1-git-send-email-alexey.brodkin@gmail.com you wrote:

From: Alexey Brodkin abrodkin@synopsys.com

Current implementation works fine for bus width = 16 bits because we never get into "if" branch.

If one sets width to 8 bits there will be 2 consequent data accesses (read/write):

1. Correct data access for 8-bit bus
2. Unconditional (and in this case incorrect) data access as if data bus

is 16-bit wide

Sorry, I don't get this.

You say, if one sets width to 8 bits, then the code fails when the bus is actually 16 bits wide?

But this is just a bad configuration then - why do we need to change the code? All that is needed is to run with a correct configuration?

Best regards,

Wolfgang Denk