Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

On Mon, Jan 11, 2016 at 02:51:39AM +0000, Dongsheng Wang wrote:

Hi Tom,

Sorry for my late reply, and thanks for your reply.

How about the following comments, following your suggestion I remove some redundant comments?

If my understanding is wrong, please correct me, thanks: #if defined(CONFIG_ARMV7_SECURE_BASE) && defined(CONFIG_ARMV7_NONSEC) /* * If CONFIG_ARMV7_SECURE_BASE is true, secure code will not * bundle with u-boot, and codes offset are fixed. Secure zone

code offsets

     * only needs to be copied from loading address to

from the loading address

     * CONFIG_ARMV7_SECURE_BASE, which is the linking and running
     * address for secure code.
     *
     * If undefine CONFIG_ARMV7_SECURE_BASE secure zone will be

If CONFIG_ARMV7_SECURE_BASE is undefined, the secure zone will be

     * included in u-boot space, and some absolute address were used

u-boot address space

     * in secure code. Accompanied by u-boot relocation secure code
     * also need to relocate the absolute address.

in secure code. The absolute addresses of the secure code also needs to be relocated along with the accompanying u-boot code.

     *
     * So DISCARD is only for CONFIG_ARMV7_SECURE_BASE.
     */
    /DISCARD/ : { *(.rel._secure*) }

#endif

Otherwise looks good, thanks!