Dear Keith,
in message OF0EE85153.67A4AEC8-ON072571E6.005FB093-072571E6.006006D2@mck.us.ray.com you wrote:
I have submitted four patches against U-Boot to Wolfgang Denk directly due to list attachment size limits.
Can you please update your patches using a current code base? I get a lot of rejects when applying your patches.
Also, please perform the following cleanup / changes:
* Make sure to adapt the Makefiles to the new build environment extensions (BUILD_DIR and depend).
* Please create just a single 'drivers/xilinx' directory instead of 5; use subdirectories where really necessary
* Clean up the Coding style (trailing white space in 65 files, C++ comments, indentation not by tabs, trailing empty lines, etc.)
* Please add correct author information; "Author: Xilinx, Inc." is not acceptable.
* Please clean up your license headers. The GPL is pretty clear that there must not be any additional restrictions on the code. Combining this with statements like "YOU ARE RESPONSIBLE FOR OBTAINING ANY THIRD PARTY RIGHTS YOU MAY REQUIRE" is IMHO not acceptable. Either this is GPL, and I have all rights, or it isn't. Also, "Use in such applications is expressly prohibited." is a restriction that is IMO incompatible with the GPL.
* Please clean up the function headers and comments. Something like this:
126 /*****************************************************************************/ 127 /** 128 * 129 * Sets up a callback function to be invoked when an assert occurs. If there 130 * was already a callback installed, then it is replaced. 131 * 132 * @param Routine is the callback to be invoked when an assert is taken 133 * 134 * @return 135 * 136 * None. 137 * 138 * @note 139 * 140 * This function has no effect if NDEBUG is set 141 * 142 ******************************************************************************/ 143 void 144 XAssertSetCallback(XAssertCallback Routine) 145 { 146 XAssertCallbackRoutine = Routine; 147 }
(i. e. 17 lines of mostly empty comment versus 1 line of code) is not acceptable. Please be descriptive, but terse.
This code is *terrybly* bloated - so much, that it's actually unreadable.
Is there any chance to clean this up such that only the *necessary* stuff gets included? You don;t want to tell me that all this is needed or even used?
Please resubmit after cleanup. Thanks.
Best regards,
Wolfgang Denk