On 25 July 2018 at 18:20, Dr. Philipp Tomsich philipp.tomsich@theobroma-systems.com wrote:
Ezequiel,
On 25 Jul 2018, at 22:31, Ezequiel Garcia ezequiel@collabora.com wrote:
On Sat, 2018-07-21 at 16:23 +0200, Dr. Philipp Tomsich wrote:
Ezequiel,
This series breaks the build (see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695). Did you test with Travis prior to submitting?
No, I haven't. It's quite odd, as the README patch just adds some documentation.
I responded to this mail, as there’s no cover letter. It’s the series breaking the build, not the README change.
I am having a hard time figuring out how could it break the build, and I do not see any logs in the travis-ci link either.
Does the direct link to the line with the error work for you: https://travis-ci.org/ptomsich/u-boot-rockchip/jobs/406351815#L1330
If not, I’ll have to copy this into a mail manually...
Right, I see it now. Thanks!
+drivers/usb/phy/rockchip_usb2_phy.c: In function 'property_enable': +arch/arm/include/asm/io.h:49:29: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] + #define __arch_putl(v,a) (*(volatile unsigned int *)(a) = (v)) + ^ +arch/arm/include/asm/io.h:117:48: note: in expansion of macro '__arch_putl' + #define writel(v,c) ({ u32 __v = v; __iowmb(); __arch_putl(__v,c); __v; }) + ^~~~~~~~~~~ +drivers/usb/phy/rockchip_usb2_phy.c:61:2: note: in expansion of macro 'writel' + writel(val, pdata->regs_phy + reg->offset); + ^~~~~~
So, it seems that since the defconfig is enabling this USB PHY driver, it's causing the failure.
I'll see if I can fix this issue and send a patch, but it seems totally orthogonal to the Ficus patchset.
Any ideas?
When you revise, I’d also prefer a ‘rockchip:’ and a ‘board:’ tag over the ARM tag …
OK, I will.
Thanks, Philipp.
On 20 Jul 2018, at 19:30, Philipp Tomsich philipp.tomsich@theobroma-systems.com wrote:
This commit adds support for RK3399 Ficus board, aka ROCK960 Enterprise Edition.
Following peripherals are tested and known to work:
- Gigabit Ethernet
- USB 2.0
- MMC
Signed-off-by: Ezequiel Garcia ezequiel@collabora.com Reviewed-by: Simon Glass sjg@chromium.org Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
arch/arm/dts/Makefile | 1 + arch/arm/dts/rk3399-ficus.dts | 564 +++++++++++++++++++++++++++++++ board/rockchip/evb_rk3399/README | 2 + configs/ficus-rk3399_defconfig | 71 ++++ 4 files changed, 638 insertions(+) create mode 100644 arch/arm/dts/rk3399-ficus.dts create mode 100644 configs/ficus-rk3399_defconfig
Acked-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot