Re: [PATCH v1] vexpress_ca9x4: Enable DM_SERIAL

On 29/01/2024 12:41, Ole Orhagen wrote:

On Fri, Jan 26, 2024 at 8:57 PM Linus Walleij <linus.walleij@linaro.org mailto:linus.walleij@linaro.org> wrote:

On Fri, Jan 26, 2024 at 1:48 PM Ole P. Orhagen
<ole.orhagen@northern.tech> wrote:

 > This commit enables support for DM_SERIAL in the vexpress_ca9x4
boards.
 >
 > When running the board with the DM_SERIAL driver, the board ran
out of
 > memory in SPL when initialising the DM serial driver.
 >
 > Thus this required an increase in the pre-allocated SRAM memory.
I did
 > increase it to 0x800, and it now works graciously.
 >
 > It could probably be set lower, but I do not see any reason not
to use the
 > available SRAM at this point.
 >
 > Also adds stdout-path to the 'chosen' node in the device tree.
 >
 > Signed-off-by: Ole P. Orhagen <ole.orhagen@northern.tech>

Nice!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org
<mailto:linus.walleij@linaro.org>>

Are you using the actual hardware, or QEMU?

I only have QEMU available, unfortunately.

Just providing some context, since I'm listed as maintainer: This board was going to be removed some time ago, but was resurrected specifically to work with QEMU. The "virt" board, at least at that time, did not support some key ARM features that we need in our testing, such as SD cards and Flash. Hence we opted to keep this board around. So compatibility with hardware is not important to us at least, unless someone else is requesting it.