Dear Allen Martin,
On Tue, Nov 06, 2012 at 02:56:37PM -0800, Marek Vasut wrote:
Dear Simon Glass,
Hi Marek,
On Tue, Nov 6, 2012 at 2:49 PM, Marek Vasut marex@denx.de wrote:
Dear Allen Martin,
Check for scancodes for arrow keys and map them to ^F/^B, ^N/^P. Control characters are used instead of ANSI sequence because the queueing code in usb_kbd doesn't handle the data increase when one keypress generates 3 keycodes. The real fix is to convert this driver to use the input subsystem and queue
If it's the real fix, then why not go for the real fix right away? :-(
Because it's a fair chunk of work
Let's either do it properly or not at all ... if I let you do these semi- complete fixes, we'll end up with a stinking pile of crap like windows ...
I'm definately on board with changing it over to use input, it seems like the right thing to do. I just wasn't signing up to do the work right now. I'm happy to help review patches though if someone else wants to jump in.
Guys ... I have two things in my mind. You want to add features, that's fine with me. But then, the merge window is closed already, so you have crapload of time to work on it. Also, if you won't do it now, noone will ever do it later.
Please, do it now. I don't see it being too much work.
btw. do you remember we've been in such place once already with some other piece of u-boot?
Best regards, Marek Vasut