On Monday 17 November 2008, Haavard Skinnemoen wrote:
Stefan Roese sr@denx.de wrote:
I could do it this way, sure. But how about this version:
static void __flash_write8(u8 value, void *addr) { __raw_writeb(value, addr); } ...
#ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS void flash_write8(u8 value, void *addr)__attribute__((weak, alias("__flash_write8"))); ... #else #define flash_read8 __flash_read8 ... #endif
We would still have the original accessor functions this way. And the resulting source code looks a little "better" to me (less #ifdef's).
Hmm...1 #ifdef vs. 1 #ifdef...I'd say that's pretty much the same ;-)
Yes right. I first thought you wanted to override the functions on a per-function basis:
#ifndef flash_write8 # define flash_write8(value, addr) __raw_writeb(value, addr) #endif #ifndef flash_write16 # define flash_write16(value, addr) __raw_writew(value, addr) #endif ...
But sure, your way works too.
OK, I'll submit a new patch version later today.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================