Re: [U-Boot] [PATCH 1/4] net/fman: Add support for 10GEC3 and 10GEC4

22 Nov 2013


      ...
-----Original Message-----
From: York Sun [mailto:yorksun@freescale.com]
Sent: Friday, November 22, 2013 1:51 AM
To: Liu Shengzhou-B36685; u-boot@lists.denx.de
Subject: Re: [PATCH 1/4] net/fman: Add support for 10GEC3 and 10GEC4
...
#ifdef CONFIG_SYS_FMAN_V3

if (fm_eth->type == FM_ETH_10G_E)
num += 8;




if (fm_eth->type == FM_ETH_10G_E) {
if (fm_eth->num >= 2)


	num -= 2;


else


	num += 8;


}

It would be nice if you can add some comments here.
[Shengzhou] ok, will do.
...
...
@@ -239,10 +245,14 @@ static void ft_fixup_port(void *blob, struct fm_eth_info
*info, char *prop)
...
* FM1_10GEC1 is enabled and  FM1_DTSEC9 is disabled, ensure that the
* dual-role MAC is not disabled, ditto for other dual-role MACs.
*/

Revise this comment to match your change.
[Shengzhou] This comment doesn't need to revise, the comment takes FM1_10GEC1 an example, 
then "ditto for other dual-role MACs", it still matches the change of this patch. Thanks.

    

Shengzhou Liu