On Fri, May 25, 2007 at 04:29:13PM +0200, Wolfgang Denk wrote:
In message 20070525142054.GE4199@enneenne.com you wrote:
This allow developers to define per board logo file into main configuration file as follow:
wwpc1100_config : unconfig @$(MKCONFIG) $(@:_config=) arm pxa wwpc1100 @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mk
I don't like this. This adds configuration information into Makefile, where it does not belong.
Please don't do this.
So where should I add this info?
--- a/Makefile +++ b/Makefile @@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk))
...
@@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc) CROSS_COMPILE = powerpc-linux- endif ifeq ($(ARCH),arm) -CROSS_COMPILE = arm-eurotech-linux-
^^^^^^^^^^^^^^^^^^^ What's that?+CROSS_COMPILE = arm-linux-
Also, this patch does not apply.
Ooops! Sorry, that was my fault... :'(
Ciao,
Rodolfo