On Tue, Jan 14, 2025 at 02:43:44PM +0100, Quentin Schulz wrote:
Hi Tom,
On 12/20/24 11:22 PM, Tom Rini wrote:
At this point in time, DM is always enabled. So if MMC is enabled, it should select DM_MMC. No drivers need to depend on DM_MMC being enabled now, so remove that from dependency lists. This now means that a number of platforms which select'd DM_MMC need to select MMC instead.
Signed-off-by: Tom Rini trini@konsulko.com
[snip]
@@ -1211,7 +1210,6 @@ config ARCH_U8500 select CPU_V7A select DM
I guess this can be removed in may places since it defaults to y and we are relying on it being set to y?
Yes, a clean-up to remove "select DM" would be good. This dates back to before everyone was converted.
[...]
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 9f2fecce3826..46513db0d6e3 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -3,7 +3,7 @@ menu "MMC Host controller Support" config MMC bool "MMC/SD/SDIO card support" default ARM || PPC || SANDBOX
- select DM_MMC if DM
- select DM_MMC help This selects MultiMediaCard, Secure Digital and Secure Digital I/O support.
@@ -39,14 +39,14 @@ config MMC_BROKEN_CD If card detection feature is broken, just poll to detect. config DM_MMC
- bool "Enable MMC controllers using Driver Model"
- bool depends on DM
We can probably remove this depends on as well since DM is implied?
Correct.
Generally, I'm wondering why we are even keeping this symbol and not merging MMC and DM_MMC together? This is not a blocker for this change though, we can go babysteps :)
What makes merging MMC and DM_MMC somewhat tricky is that DM is not required in SPL/TPL. So yeah, small steps here is the way forward.