Hi Stephen,
On 6 October 2015 at 09:14, Simon Glass sjg@chromium.org wrote:
Hi Stephen,
On 6 October 2015 at 00:00, Stephen Warren swarren@wwwdotorg.org wrote:
From: Stephen Warren swarren@nvidia.com
The board PCI setup code may control regulators that are required simply to bring up the PCI controller itself (or PLLs, IOs, ... it uses). Move the call to this function earlier so that all board-provided resources are ready early enough for everything to work.
Signed-off-by: Stephen Warren swarren@nvidia.com
drivers/pci/pci_tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci_tegra.c b/drivers/pci/pci_tegra.c index 177d48dde477..bf078b3369ba 100644 --- a/drivers/pci/pci_tegra.c +++ b/drivers/pci/pci_tegra.c @@ -618,8 +618,6 @@ static int tegra_pcie_power_on(struct tegra_pcie *pcie) return err; }
tegra_pcie_board_init();err = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_PCIE, PERIPH_ID_PCIE); if (err < 0) {@@ -1164,6 +1162,8 @@ void pci_init_board(void) const void *fdt = gd->fdt_blob; int count, nodes[1];
tegra_pcie_board_init();count = fdtdec_find_aliases_for_id(fdt, "pcie-controller", COMPAT_NVIDIA_TEGRA124_PCIE, nodes, ARRAY_SIZE(nodes));-- 1.9.1
It might be a good time to move Tegra to driver model for PCI.
I had a look at this and will send some patches.
Regards, Simon