Re: [U-Boot] [PATCH] ARM: mvebu: don't dereference null bd pointer

Hi Chris,

On 22.10.19 09:05, Chris Packham wrote:

As mentioned in doc/README.arm-relocation gd->bd is not available in dram_init() so we shouldn't attempt to access it.

Signed-off-by: Chris Packham judge.packham@gmail.com

arch/arm/mach-mvebu/dram.c | 10 ---------- 1 file changed, 10 deletions(-)

diff --git a/arch/arm/mach-mvebu/dram.c b/arch/arm/mach-mvebu/dram.c index fa8c799a462e..ba8ebc62887f 100644 --- a/arch/arm/mach-mvebu/dram.c +++ b/arch/arm/mach-mvebu/dram.c @@ -281,16 +281,6 @@ int dram_init(void) size = MVEBU_SDRAM_SIZE_MAX; }

• for (; i < CONFIG_NR_DRAM_BANKS; i++) {

• /* If above loop terminated prematurely, we need to set
  

•  * remaining banks' start address & size as 0. Otherwise other
  

•  * u-boot functions and Linux kernel gets wrong values which
  

•  * could result in crash */
  

• gd->bd->bi_dram[i].start = 0;
  

• gd->bd->bi_dram[i].size = 0;
  

• }

How did you spot this issue? Did you see some crash / oops on one of your boards lately? I'm asking since I've never seen any issues with this code.

Thanks, Stefan