Re: [U-Boot] [PATCH 1/2] common/console: coding style cleanup

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1233486771-10411-1-git-send-email-plagnioj@jcrosoft.com you wrote:

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

common/console.c | 97 ++++++++++++++++++++++++++++-------------------------- 1 files changed, 50 insertions(+), 47 deletions(-)

diff --git a/common/console.c b/common/console.c index 89aeab6..851b0f8 100644 --- a/common/console.c +++ b/common/console.c @@ -106,39 +106,39 @@ int cd_count[MAX_FILES];

• only from fgetc() which assures it.
• No attempt is made to demultiplex multiple input sources.

*/ -static int iomux_getc(void) +static int iomux_getc (void)

...

-static int iomux_tstc(int file) +static int iomux_tstc (int file)

NAK.

This Linux kernel coding style does NOT insert spaces between function names; your patch makes the style worse, not better.

Best regards,

Wolfgang Denk