Dear Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 15:33 Mon 30 Mar , Dirk Behme wrote:
Jean-Christophe PLAGNIOL-VILLARD wrote:
Hi Wolfgang,
Please pull The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b: Wolfgang Denk (1): VCMA9: fix compile errors
are available in the git repository at:
git://git.denx.de/u-boot-arm.git master
Jean-Christophe PLAGNIOL-VILLARD (19): s3c4510b: move specific code to soc directory s3c44b0: move i2c driver to drivers/i2c s3c44b0: move rtc driver to drivers/rtc s3c44b0: move serial driver to drivers/serial s3c44b0: extract cache from cpu.c sa1100: move serial driver to drivers/serial netarm: move serial driver to drivers/serial imx31: move serial driver to drivers/serial s3c64xx: move usb driver to drivers/usb ks8695: move serial driver to drivers/serial lpc2292: move serial driver to drivers/serial arm720t/clps7111: move serial driver to drivers/serial omap3: remove duplicate interrupts code
This patch isn't finally reviewed
http://lists.denx.de/pipermail/u-boot/2009-March/049762.html
Please remove it from the pull request until everybody agreed
this duplicated code
It would be nice if you could give the exact file in which you found the other/original version of this code. As already mentioned I'd like to compare/review it.
so I'll remove it anyway I do not want duplicated code
It would be nice if we could agree on a common way how to improve (remove?) this code. And not just "I'll remove it anyway". Sorry if I misunderstood this, but it could be understood as "I will remove it independent of what other people think and do".
imx: move serial driver to drivers/serial davinci: move nand driver to drivers/mtd/nand davinci: move i2c driver to drivers/i2c s3c24x0: move serial driver to drivers/serial s3c24x0: move i2c driver to drivers/i2c s3c2410: move nand driver to drivers/mtd/nandIt seems to me that
http://lists.denx.de/pipermail/u-boot/2009-March/049662.html
This one is NACK
? This link just links to a mail with two questions, not a patch ?
is unanswered. Therefore again:
What's about
http://lists.denx.de/pipermail/u-boot/2009-March/049146.html
?
I'm not statisfy about this one I'm looking on an other implementation so this patch will wait a few more days
It would be nice if you could share your ideas/doubts/findings so that we can work together on improving this code.
Dirk