-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Michael Walle Sent: Thursday, November 21, 2019 6:18 PM To: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v3 1/3] spi: nxp_fspi: new driver for the FlexSPI controller
Am 2019-11-06 00:03, schrieb Michael Walle:
This is a port of the kernel's spi-nxp-fspi driver. It uses the new spi-mem interface and does not expose the more generic spi-xfer interface. The source was taken from the v5.3-rc3 tag.
The port was straightforward:
- remove the interrupt handling and the completion by busy polling the controller
- remove locks
- move the setup of the memory windows into claim_bus()
- move the setup of the speed into set_speed()
- port the device tree bindings from the original fspi_probe() to ofdata_to_platdata()
There were only some style change fixes, no change in any logic. For example, there are busy loops where the return code is not handled correctly, eg. only prints a warning with WARN_ON(). This port intentionally left most functions unchanged to ease future bugfixes.
This was tested on a custom LS1028A board. Because the LS1028A doesn't have proper clock framework support, changing the clock speed was not tested. This also means that it is not possible to change the SPI speed on LS1028A for now (neither is it possible in the linux driver).
Signed-off-by: Michael Walle michael@walle.cc Reviewed-by: Jagan Teki jagan@amarulasolutions.com
changes since v1:
- fixed typo, thanks Jagan
changes since v2:
- none
Ping. any news on this?
Will pick this patch in next merge window
-michael
-priyankajain