On Thu, Apr 06, 2023 at 05:38:11PM +0200, Jerome Neanne wrote:
TPS6594 is a Power Management IC which provides regulators and others features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can communicate through the I2C or SPI interfaces. TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives.
This series fixes LDO voltage conversion for TPS6594 PMIC, it adds support for its derivatives.
The features implemented are:
- Regulators
- WD disable
WD disable is not a watchdog driver implementation. Watchdog is active by default causing a reboot even if not used. This implementation allow to disable the watchdog at boot time.
Due to current situation with upstream u-boot dts, this patch suite can be applied only after u-boot dts upstream is resynched on latest Linux dts. Link: https://gist.github.com/nmenon/030b11b085473fa008145429b39fcc75
This should be applied on top of Linux patch series (for dts inheritence) Link: https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/ Link: https://lore.kernel.org/all/20230328091448.648452-1-eblanc@baylibre.com/
Tested on boards listed below (resynched manually on Linux 6.3 dts)
Supported boards:
- j721eXSOMXEVM:
Link: https://www.ti.com/tool/J721EXSOMXEVM
- AM62A-SKEVM:
Link: https://www.ti.com/tool/SK-AM62A-LP
basic tests: => pmic list => regulator list => regulator dev reg_name_to_be_tested => regulator info => regulator value => regulator value my_test_val => regulator value Check WD reset is not happening when dip switch SW2 on GPIO8 is High.
Jerome Neanne (4): drivers: pmic: TPS65941 add support for WD disable drivers: regulator: Fixes for TPS65941 LDO voltage conversion configs: j721e_evm: Add support for TPS65941 PMICs on j721e TI EVM board board: ti: k3-j721e: Force TPS65941 PMIC WD disable on j721e TI EVM board
Jerome Neanne (4): DONOTMERGE: arm: dts: k3-j721e: u-boot overlay for TI tps6594 PMIC DONOTMERGE: arm: dts: k3-j721e: refactor r5 board file to use Linux dts tps6594 description DONOTMERGE: arm: dts: k3-j721e: realign node name on linux dts name DONOTMERGE: arm: dts: k3-am62a7-sk: Add TI TPS6593 PMIC support
Julien Panis (1): configs: am62ax_evm_a53: Enable support for TI TPS6593 PMIC
arch/arm/dts/k3-am62a7-sk-u-boot.dtsi | 24 ++++++- .../k3-j721e-common-proc-board-u-boot.dtsi | 21 ++++++ .../k3-j721e-r5-common-proc-board-u-boot.dtsi | 2 +- .../arm/dts/k3-j721e-r5-common-proc-board.dts | 48 ++++++------- board/ti/j721e/evm.c | 8 +++ configs/am62ax_evm_a53_defconfig | 9 ++- configs/j721e_evm_a72_defconfig | 9 +++ drivers/power/pmic/tps65941.c | 36 ++++++++++ drivers/power/regulator/tps65941_regulator.c | 71 ++++++++++++++++--- include/power/tps65941.h | 25 ++++++- 10 files changed, 213 insertions(+), 40 deletions(-)
The code seems fine. The defconfig changes don't seem to have been done with a "savedefconfig" (one add a blank line at the end for example), but you can hold off on v2'ing things, barring other feedback, until the DTS situation is resolved.