Re: [PATCH 5/6] net: zynq: Use generic_phy_valid() helper

On 9/1/23 00:16, Jonas Karlman wrote:

The documentation for struct phy state that "The content of the structure is managed solely by the PHY API and PHY drivers".

Change to use the generic_phy_valid() helper to check if phy is valid.

Fixes: 10c50b1facbf ("net: zynq: Add support for PHY configuration in SGMII mode") Signed-off-by: Jonas Karlman jonas@kwiboo.se

---

drivers/net/zynq_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c index f3cdfb0275d0..3377e669f2f6 100644 --- a/drivers/net/zynq_gem.c +++ b/drivers/net/zynq_gem.c @@ -890,7 +890,8 @@ static int zynq_gem_probe(struct udevice *dev) if (ret) goto err3;

• if (priv->interface == PHY_INTERFACE_MODE_SGMII && phy.dev) {

• if (priv->interface == PHY_INTERFACE_MODE_SGMII &&

•    generic_phy_valid(&phy)) {
  

  if (IS_ENABLED(CONFIG_DM_ETH_PHY)) { if (device_is_compatible(dev, "cdns,zynqmp-gem") || device_is_compatible(dev, "xlnx,zynqmp-gem")) {

Applied. M