Am Mittwoch 23 September 2009 18:49:34 schrieb Stefan Roese:
Hi Niklaus,
On Wednesday 23 September 2009 17:22:47 Niklaus Giger wrote:
Adds a HCU5 board specific cmd reghcu5 to dump about 140 internal register which define the HW configuration. Needed for documentation purposes and to compare different settings.
Apart from Peter's comments, I also have a more general comment. Please correct me if I'm wring, but this register dump doesn't seem to be HCU5 specific, but PPC440EPx specific. If this is the case, we (you) should probably move this code into the cpu/ppc4xx directory. Perhaps something like:
cpu/ppc4xx/440epx_regdump.c
What do you think?
I feel honoured if you consider this patch useful for other boards, too. I will rename the cmd to "440epx_regdump" unless you have a better idea.
Patch will follow tomorrow from my office.
Will remove the reference to our internal documentation, too.
Best regards
Cheers, Stefan