Hi Tom,
Tom Rini trini@konsulko.com writes:
On Mon, Jan 21, 2019 at 12:28:42PM +0100, Maciej Zagrabski wrote:
Manufacturing process changes caused that several versions of chiliSOM with different memory chips are present on market. Patch introduces method for selecting actual memory chip on som through Kconfig. Patch creates space for adding more memory chips in future.
Memory chip configuration is constructed by preprocesor basing on DDR3 part no from Kconfig. To do this, Makefile translates string from Kconfig into preprocesor token.
Signed-off-by: Maciej Zagrabski maciej.zagrabski@grinn-global.com
[snip]
diff --git a/arch/arm/mach-omap2/am33xx/Makefile b/arch/arm/mach-omap2/am33xx/Makefile index 61c76d045f3..81c7a82f21e 100644 --- a/arch/arm/mach-omap2/am33xx/Makefile +++ b/arch/arm/mach-omap2/am33xx/Makefile @@ -26,3 +26,4 @@ obj-y += fdt.o obj-$(CONFIG_CLOCK_SYNTHESIZER) += clk_synthesizer.o
obj-$(CONFIG_AM33XX_CHILISOM) += chilisom.o +CFLAGS_chilisom.o := -DCHILISOM_DDR3_CHIP_NAME=$(CONFIG_CHILISOM_DDR3_CHIP_NAME)
I'm not super happy with this. Can't we use __stringify() in the code directly instead?
The problem is that we need the opposite convertion. Kconfig is generating macro value with "" quotes. We need that macro without quotes in C code.
-- Marcin Niestrój