Re: [U-Boot] [PATCH v2 4/4] net: NC-SI setup and handling

On Tue, 18 Jun 2019 at 01:38, Samuel Mendoza-Jonas sam@mendozajonas.com wrote:

Add the handling of NC-SI ethernet frames, and add a check at the start of net_loop() to configure NC-SI before starting other network commands. This also adds an "ncsi" command to manually start NC-SI configuration.

Signed-off-by: Samuel Mendoza-Jonas sam@mendozajonas.com

v2: Update ncsi command help text

cmd/Kconfig | 8 ++++++++ cmd/net.c | 18 ++++++++++++++++++ include/net.h | 2 +- net/net.c | 27 ++++++++++++++++++++++++++- 4 files changed, 53 insertions(+), 2 deletions(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig index 0badcb3fe0..9851b04972 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1332,6 +1332,14 @@ config CMD_LINK_LOCAL help Acquire a network IP address using the link-local protocol

+config CMD_NCSI

•   bool "ncsi"
  

•   depends on PHY_NCSI
  

•   help
  

•     Manually configure the attached NIC via NC-SI.
  

•     Normally this happens automatically before other network
  

•     operations.
  

Do we need to make it even clearer that "this command not required to use NCSI"?

I'm thinking of future me wondering if we should put this in openbmc builds or not. It would be good to have your advice on this.

Cheers,

Joel