Hi Tom,
Thanks for reviewing! I am not quite sure about the tests which you refer to. Is it the CI in the gitlab? I think this patch is simple and it doesn’t occur any errors during my work these days, thus I tested it manually which didn’t throw any problems, and sent it. Could you please give me some hints about the broken tests? If it is a CI, could you please give me the link to the error information?
Thanks!
Regards, Hanyuan
2024年3月2日 05:37，Tom Rini trini@konsulko.com 写道：
On Sat, Feb 17, 2024 at 09:54:43PM +0800, Hanyuan Zhao wrote:
This commit allows user to determine whether to have history recording in command-line. Previously the history data as uninitialized static array would not directly take much space in binary file since it only marks size in the binary. However now it asks to allocate space. By connecting the original CMD_HISTORY flag in Kconfig, users could unset the whole history function, and the memory usage could be eased, if the history function is not used at all.
Signed-off-by: Hanyuan Zhao hanyuan-z@qq.com
cmd/Kconfig | 1 + common/cli_readline.c | 44 ++++++++++++++++++++++++------------------- 2 files changed, 26 insertions(+), 19 deletions(-)
This breaks current tests, please re-test, thanks.
-- Tom