Re: [U-Boot] [PATCH V5 08/32] misc: add i.MX8 misc driver

Hi Peng,

On Wed, 26 Sep 2018 21:52:32 +0800 Peng Fan peng.fan@nxp.com wrote:

Add i.MX8 MISC driver to handle the communication between A35 Core and SCU.

Signed-off-by: Peng Fan peng.fan@nxp.com

Reviewed-by: Anatolij Gustschin agust@denx.de

Looks good, please see some minor comment below.

...

+static int imx8_scu_bind(struct udevice *dev) +{

• struct imx8_scu *priv = dev_get_priv(dev);
• int ret;
• struct udevice *child;
• int node;
• debug("%s(dev=%p)\n", __func__, dev);
• node = fdt_node_offset_by_compatible(gd->fdt_blob, -1,

• 			     "fsl,imx8qxp-clk");
  

• if (node < 0)

• panic("No clk node found\n");
  

• ret = lists_bind_fdt(dev, offset_to_ofnode(node), &child);
• if (ret)

• return ret;
  

• priv->clk = child;
• node = fdt_node_offset_by_compatible(gd->fdt_blob, -1,

• 			     "fsl,imx8qxp-iomuxc");
  

• if (node < 0)

• panic("No clk node found\n");
  

"No clk ..." is wrong here, a copy-paste reminder, it seems. Please add "No iomuxc ..." here.

Thanks,

Anatolij