In message 20051103120523.GA3894@orphique you wrote:
Generated against testing-NAND branch.
Signed-off-by: Ladislav Michl ladis@linux-mips.org
CHANGELOG:
- Update NAND code to be based on what is in Linux-2.6.14 Patch by Ladislav Michl, 3 Nov 2005
Sorry, but this patch needs major cleanup. I get:
nand_base.c: In function 'nand_wait_ready': nand_base.c:573: warning: implicit declaration of function 'reset_timer_masked' nand_base.c:579: warning: implicit declaration of function 'get_timer_masked' In file included from nand_ids.c:18: /home/wd/git/u-boot/mailing-list/include/linux/mtd/nand.h:498: warning: 'struct erase_info' declared i nside parameter list /home/wd/git/u-boot/mailing-list/include/linux/mtd/nand.h:498: warning: its scope is only this definit ion or declaration, which is probably not what you want In file included from cmd_jffs2.c:105: /home/wd/git/u-boot/mailing-list/include/linux/mtd/nand.h:498: warning: 'struct erase_info' declared i nside parameter list /home/wd/git/u-boot/mailing-list/include/linux/mtd/nand.h:498: warning: its scope is only this definit ion or declaration, which is probably not what you want drivers/nand/libnand.a(nand_base.o): In function `nand_wait_ready': /.automount/castor-vlab/root/home/wd/git/u-boot/mailing-list/drivers/nand/nand_base.c:573: undefined r eference to `reset_timer_masked' /.automount/castor-vlab/root/home/wd/git/u-boot/mailing-list/drivers/nand/nand_base.c:579: undefined r eference to `get_timer_masked' make: *** [u-boot] Error 1
Note that "reset_timer_masked" and "get_timer_masked" are functions which are architecture-specific and should NOT be used in common code.
Actually, you should never need to use these in the the first place. They are only needed for broken ports.
Please get rid of these, clean up the other errors, and resubmit.
Thanks.
Best regards,
Wolfgang Denk